[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files
Min-Yih Hsu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 17 16:23:36 PST 2020
myhsu added a comment.
In D88389#2399680 <https://reviews.llvm.org/D88389#2399680>, @rengolin wrote:
> In D88389#2399389 <https://reviews.llvm.org/D88389#2399389>, @RKSimon wrote:
>
>> Is it worth trying to avoid adding/deleting the *Dummy* files in the patch series? @rengolin any thoughts ?
>
> I had the same though while reading through... I'm not sure how "necessary" is the dummy file.
>
> So far, new targets haven't done that, but maybe this is a side-effect of trying to make all commits build,
Correct, I think the CodeGen required symbols like `LLVMInitializeM68kTargetInfo`, so I need some place to put it.
> which hasn't been a hard requirement on other back-ends, I think.
Oh, from the discussion on mailing list I thought this is a requirement.
> I would mildly prefer to not having those files at all, if possible.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88389/new/
https://reviews.llvm.org/D88389
More information about the llvm-commits
mailing list