[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 05:40:49 PST 2020


rengolin added a comment.

In D88389#2399389 <https://reviews.llvm.org/D88389#2399389>, @RKSimon wrote:

> Is it worth trying to avoid adding/deleting the *Dummy* files in the patch series? @rengolin any thoughts ?

I had the same though while reading through... I'm not sure how "necessary" is the dummy file.

So far, new targets haven't done that, but maybe this is a side-effect of trying to make all commits build, which hasn't been a hard requirement on other back-ends, I think.

I would mildly prefer to not having those files at all, if possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389



More information about the llvm-commits mailing list