[PATCH] D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu marked 4 inline comments as done.
myhsu added inline comments.


================
Comment at: llvm/utils/TableGen/CodeBeadsGen.cpp:50
+
+  unsigned Length = 192;
+  unsigned Size = 8;
----------------
RKSimon wrote:
> myhsu wrote:
> > craig.topper wrote:
> > > Where do these numbers come from? Are they specific to 68K?
> > no really...this number depends on maximum bit length among all code beads. As the TODO comment on line 55 suggested we should have a way to evaluate this dynamically. Also the for loop on line 84 need this number to reverse the byte order
> Please add a comment explaining these magic numbers.
Eventually I decided to just fix that TODO so the next revision will not have that magic number anymore


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88385/new/

https://reviews.llvm.org/D88385