[PATCH] D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 16:01:40 PST 2020


Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/include/llvm/Target/Target.td:638
+  /// its logical operands to corresponding MI operands.
+  bit UseLogicalOperandMappings = 0;
+
----------------
Before you push this, Target.td will use 'true' and 'false'.


================
Comment at: llvm/utils/TableGen/CodeBeadsGen.cpp:33
+  CodeBeadsGen(RecordKeeper &R) : Records(R) {}
+  void run(raw_ostream &o);
+};
----------------
It's conventional to call the output stream OS.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88385/new/

https://reviews.llvm.org/D88385



More information about the llvm-commits mailing list