[PATCH] D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

Have you tried to change kAddressSpaceSize above?



================
Comment at: compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cpp:942
 
+#if !(SANITIZER_SOLARIS && defined(__sparcv9))
 TEST(SanitizerCommon, SizeClassAllocator32Iteration) {
----------------
Better approach is to use:
```
#if defined(_MSC_VER) && defined(_DLL)
#define MAYBE_StrDupOOBTest DISABLED_StrDupOOBTest
#else
#define MAYBE_StrDupOOBTest StrDupOOBTest
#endif

TEST(AddressSanitizer, MAYBE_StrDupOOBTest) {
```
this way the test at least compiles on the platform.

But it's going to make the file inconsistent.
So you like you can update the file with MAYBE_ in a separate patch.
But feel free to keep as-is.






Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91622/new/

https://reviews.llvm.org/D91622