[PATCH] D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 17 05:12:48 PST 2020
ro created this revision.
ro added a reviewer: vitalybuka.
ro added a project: Sanitizers.
Herald added subscribers: Sanitizers, fedor.sergeev, jyknight.
ro requested review of this revision.
As reported in PR 48202, two allocator tests `FAIL` on Solaris/sparcv9, presumably because Solaris uses the full 64-bit address space and the allocator cannot deal with that:
SanitizerCommon-Unit :: ./Sanitizer-sparcv9-Test/SanitizerCommon.CombinedAllocator32Compact
SanitizerCommon-Unit :: ./Sanitizer-sparcv9-Test/SanitizerCommon.SizeClassAllocator32Iteration
If there's no proper fix, I'd like to disable the tests.
Tested on `sparcv9-sun-solaris2.11`.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D91622
Files:
compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cpp
Index: compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cpp
===================================================================
--- compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cpp
+++ compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cpp
@@ -701,9 +701,11 @@
}
#endif
+#if !(SANITIZER_SOLARIS && defined(__sparcv9))
TEST(SanitizerCommon, CombinedAllocator32Compact) {
TestCombinedAllocator<Allocator32Compact>();
}
+#endif
template <class Allocator>
void TestSizeClassAllocatorLocalCache() {
@@ -937,9 +939,11 @@
#endif
#endif
+#if !(SANITIZER_SOLARIS && defined(__sparcv9))
TEST(SanitizerCommon, SizeClassAllocator32Iteration) {
TestSizeClassAllocatorIteration<Allocator32Compact>();
}
+#endif
TEST(SanitizerCommon, LargeMmapAllocatorIteration) {
LargeMmapAllocator<NoOpMapUnmapCallback> a;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91622.305748.patch
Type: text/x-patch
Size: 869 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201117/a048bd5e/attachment.bin>
More information about the llvm-commits
mailing list