[PATCH] D91324: [NewPM] Disable PreserveCFGChecker and add regression unit tests

Tue Nov 17 08:26:38 PST 2020

yrouban added a comment.

In D91324#2398657 <https://reviews.llvm.org/D91324#2398657>, @skatkov wrote:

> Do I understand correctly that with -verify-cfg-preserved=true all new tests fail?

Only //PassManagerTest.FunctionPassCFGCheckerInvalidateAnalysis// does fail.
The other two (//PassManagerTest.FunctionPassCFGCheckerWrapped// and //PassManagerTest.FunctionPassCFGChecker//) pass.

> I would suggest to move new tests to separate test file. Mark it as expected to fail and do not change the value of -verify-cfg-preserved in this patch.
> Then in a separate commit, turn the option be default and remove expected fail.
> After that fix the issue and turn the option to on back.
>
> If it is possible actually :)

I did not find a way to exclude except changing the line 'TEST_F(PassManagerTest, ...) to just a func definition' to skip this test. But this way the tests will not be run.
So, if you do not mind, I will land as is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91324/new/

https://reviews.llvm.org/D91324