[PATCH] D91324: [NewPM] Disable PreserveCFGChecker and add regression unit tests

[Serguei Katkov via Phabricator via llvm-commits]

skatkov accepted this revision.
skatkov added a comment.
This revision is now accepted and ready to land.

Do I understand correctly that with -verify-cfg-preserved=true all new tests fail?

I would suggest to move new tests to separate test file. Mark it as expected to fail and do not change the value of -verify-cfg-preserved in this patch.
Then in a separate commit, turn the option be default and remove expected fail.
After that fix the issue and turn the option to on back.

If it is possible actually :)



================
Comment at: llvm/unittests/IR/PassManagerTest.cpp:811
+// Run SimplifyCFGPass that makes CFG changes and reports PreservedAnalyses
+// accordingly. So the CFGChecker does not complain.
+TEST_F(PassManagerTest, FunctionPassCFGChecker) {
----------------
could you please be more precise. Specifically state explicitly what is "accordingly".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91324/new/

https://reviews.llvm.org/D91324