[PATCH] D91530: [llvm-readobj] - Introduce `forEachRelocationDo` helper. NFCI.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 23:54:47 PST 2020


grimar added a comment.

In D91530#2398695 <https://reviews.llvm.org/D91530#2398695>, @MaskRay wrote:

> I don't get why `RelRelaReloc` is needed. Can you describe a bit about it?

Previously the `Relocation` was the struct which allowed to handle `Rel/Rela` relocations.
I've reworked it so that it how also is able to keep `Relr` relocations.
That way it allows to represent 3 types of relocations instead of previous 2 and have a common code for iterations over them.

`RelRelaReloc` is now a helper class that is used to represent `Rel/Rela` relocations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91530/new/

https://reviews.llvm.org/D91530



More information about the llvm-commits mailing list