[PATCH] D91530: [llvm-readobj] - Introduce `forEachRelocationDo` helper. NFCI.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 20:51:33 PST 2020


MaskRay added a comment.

I don't get why `RelRelaReloc` is needed. Can you describe a bit about it?



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:817
 
+  std::function<void(const Relocation<ELFT> &R, unsigned Ndx,
+                     const Elf_Shdr &Sec, const Elf_Shdr *Symtab)>
----------------
It is slightly unfortunate that this cannot use `function_ref` because the variable used for initialization is local.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91530/new/

https://reviews.llvm.org/D91530



More information about the llvm-commits mailing list