[PATCH] D90040: [AsmPrinter] Use getMnemonic for instruction-mix remark.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 16:02:20 PST 2020


arsenm added inline comments.


================
Comment at: llvm/include/llvm/MC/MCStreamer.h:457
+  /// access to a instruction printer.
+  virtual StringRef getMnemonic(MCInst &MI) { return ""; }
+
----------------
paquette wrote:
> Would it make sense to make this return an `Optional` to make it clear that this may not necessarily return a mnemonic?
empty string works well enough


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90040/new/

https://reviews.llvm.org/D90040



More information about the llvm-commits mailing list