[PATCH] D90040: [AsmPrinter] Use getMnemonic for instruction-mix remark.
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 16 14:32:11 PST 2020
paquette added inline comments.
================
Comment at: llvm/include/llvm/MC/MCStreamer.h:457
+ /// access to a instruction printer.
+ virtual StringRef getMnemonic(MCInst &MI) { return ""; }
+
----------------
Would it make sense to make this return an `Optional` to make it clear that this may not necessarily return a mnemonic?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90040/new/
https://reviews.llvm.org/D90040
More information about the llvm-commits
mailing list