[compiler-rt] c8f4e06 - [sanitizer] Fix test on arm 32bit

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 02:51:55 PST 2020


Rainer Orth via llvm-commits <llvm-commits at lists.llvm.org> writes:

> ISTM that the (fake) stack ids for the two stack traces have changed
> after the patch, so the two lines in the EXPECT_EXIT pattern have
> likewise to be inverted.  Better yet, make the stack ids deterministic
> to avoid this issue in the future.

indeed: this patch

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sst.patch
Type: text/x-patch
Size: 802 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201116/7e6aa3f4/attachment.bin>
-------------- next part --------------

fixed the failure for me on Linux/x86_64.  It also fixed the test on
SPARC where it had failed before since GetPreviousInstructionPc returns
pc - 8, not pc - 1 as expected by the test.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


More information about the llvm-commits mailing list