[compiler-rt] c8f4e06 - [sanitizer] Fix test on arm 32bit

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 00:52:26 PST 2020


"Yung, Douglas via llvm-commits" <llvm-commits at lists.llvm.org> writes:

> Your fix to this test appears to have broken it on one of the build bots:
>
> http://lab.llvm.org:8011/#/builders/112/builds/1127

It's the same on the Solaris/amd64 buildbot:

	http://lab.llvm.org:8014/#/builders/16

as well as in a local Linux/x86_64 build.

ISTM that the (fake) stack ids for the two stack traces have changed
after the patch, so the two lines in the EXPECT_EXIT pattern have
likewise to be inverted.  Better yet, make the stack ids deterministic
to avoid this issue in the future.

BTW., any reason why this patch wasn't posted on Phabricator?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


More information about the llvm-commits mailing list