[PATCH] D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause

[Valentin Clement via Phabricator via llvm-commits]

clementval requested changes to this revision.
clementval added inline comments.


================
Comment at: flang/include/flang/Parser/parse-tree.h:590
+  ENUM_CLASS(IntrinsicProcedure, MAX, MIN, IAND, IOR, IEOR);
+  std::variant<DefinedOpName, IntrinsicOperator, IntrinsicProcedure> u;
 };
----------------
tskeith wrote:
> This change doesn't belong here, it should be in OpenMP-specific code. A defined-operator in Fortran does not include any intrinsic procedures.
Thanks @tskeith for looking at this. +1


================
Comment at: flang/include/flang/Semantics/symbol.h:403
+  ENUM_CLASS(
+      OtherKind, Name, DefinedOp, Assignment, Concat, MAX, MIN, IAND, IOR, IEOR)
   ENUM_CLASS(DefinedIo, // defined io
----------------
Not sure if this is the way to go since you add only a fraction of intrinsic procedure her


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90697/new/

https://reviews.llvm.org/D90697