[PATCH] D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause

[Tim Keith via Phabricator via llvm-commits]

tskeith requested changes to this revision.
tskeith added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/include/flang/Parser/parse-tree.h:590
+  ENUM_CLASS(IntrinsicProcedure, MAX, MIN, IAND, IOR, IEOR);
+  std::variant<DefinedOpName, IntrinsicOperator, IntrinsicProcedure> u;
 };
----------------
This change doesn't belong here, it should be in OpenMP-specific code. A defined-operator in Fortran does not include any intrinsic procedures.


================
Comment at: flang/lib/Parser/Fortran-parsers.cpp:110
+    construct<DefinedOperator>(definedOpName) ||
+    construct<DefinedOperator>(intrinsicProcedure))
 
----------------
Same problem here. This accepts `interface operator(max)` which is not valid Fortran.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90697/new/

https://reviews.llvm.org/D90697