[PATCH] D91437: [AMDGPU][GlobalISel] Fix lowerShlSat

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 09:14:27 PST 2020


foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:6076
   }
-  auto Ov = MIRBuilder.buildICmp(CmpInst::ICMP_NE, Ty, LHS, Orig);
+  auto Ov = MIRBuilder.buildICmp(CmpInst::ICMP_NE, LLT::scalar(1), LHS, Orig);
   MIRBuilder.buildSelect(Res, Ov, SatVal, Result);
----------------
arsenm wrote:
> BoolTy?
Use BoolTy here. Otherwise it won't work for vector types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91437/new/

https://reviews.llvm.org/D91437



More information about the llvm-commits mailing list