[PATCH] D91437: [AMDGPU][GlobalISel] Fix lowerShlSat

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:6076
   }
-  auto Ov = MIRBuilder.buildICmp(CmpInst::ICMP_NE, Ty, LHS, Orig);
+  auto Ov = MIRBuilder.buildICmp(CmpInst::ICMP_NE, LLT::scalar(1), LHS, Orig);
   MIRBuilder.buildSelect(Res, Ov, SatVal, Result);
----------------
BoolTy?


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-sshlsat.mir:221
+    ; GFX8: [[C:%[0-9]+]]:_(s32) = G_CONSTANT i32 8
+    ; GFX8: [[LSHR:%[0-9]+]]:_(s32) = G_LSHR [[COPY]], [[C]](s32)
+    ; GFX8: [[C1:%[0-9]+]]:_(s32) = G_CONSTANT i32 16
----------------
I'm surprised there are this many changes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91437/new/

https://reviews.llvm.org/D91437