[PATCH] D91383: [BasicAA] Make alias GEP positive offset handling symmetric

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

I wouldn't be surprised if there are other asymmetries, thank you for digging further here.



================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:1452
+        (-GEP1BaseOffset).uge(V2Size.getValue()))
+      return NoAlias;
 
----------------
jdoerfert wrote:
> nikic wrote:
> > jdoerfert wrote:
> > > Copy paste error?
> > Um, where? I'm not seeing it ^
> I think I was simply confused. Maybe today is not the day to finish this review (for me). I'll give it another shot tomorrow ;)
I believe this is correct :-).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91383/new/

https://reviews.llvm.org/D91383