[PATCH] D91383: [BasicAA] Make alias GEP positive offset handling symmetric

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 13:40:09 PST 2020


jdoerfert added inline comments.


================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:1452
+        (-GEP1BaseOffset).uge(V2Size.getValue()))
+      return NoAlias;
 
----------------
nikic wrote:
> jdoerfert wrote:
> > Copy paste error?
> Um, where? I'm not seeing it ^
I think I was simply confused. Maybe today is not the day to finish this review (for me). I'll give it another shot tomorrow ;)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91383/new/

https://reviews.llvm.org/D91383



More information about the llvm-commits mailing list