[PATCH] D91275: [FileCheck] Disallow unused prefixes in llvm/test/Analysis

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 08:17:40 PST 2020


mtrofin added a comment.

In D91275#2390691 <https://reviews.llvm.org/D91275#2390691>, @RKSimon wrote:

> So I'm clear - the final patch is just the lit.local.cfg changes? AFAICT the changes to arith-* are just examples that aren't actually needed

Not sure what you mean by 'final' - this is a patch to "stop the bleeding" in test/Analysis.

Happy to address the 2 arith-* cases if that's the case - I'd still leave the %FileCheckWithUnusedPrefixes% so we can use them elsewhere - i.e. for scripted fixups (with a "FIXME: is this intended?") for folders that don't appear to be maintained, or for folders where this is the intent (without the FIXME there, of course).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91275/new/

https://reviews.llvm.org/D91275



More information about the llvm-commits mailing list