[PATCH] D91275: [FileCheck] Disallow unused prefixes in llvm/test/Analysis

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D91275#2390594 <https://reviews.llvm.org/D91275#2390594>, @jhenderson wrote:

> Looks okay, but I'm not really up to speed on the implications of lit substitutions, so it would be better for someone else to review if possible. In the ideal world, we'll revert this and any similar patches and just use the option explicitly, once we've fixed all the tests and changed the default to reduce obfuscation, in my opinion, but I'm not sure it's a big issue.

Right - when it's all done, meaning either prefixes are removed or test maintainers believe unused ones are intentional, we can:

- flip the default
- undo this change
- s/%FileCheckWithUnusedPrefixes%/--allow-unused-prefixes=true/g


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91275/new/

https://reviews.llvm.org/D91275