[PATCH] D88433: [IRMover] Fix up "CG Profile" MDNode after RAUW

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with a couple minor changes noted below, also the description needs an update as it still references fixing up the nodes.



================
Comment at: llvm/test/Transforms/FunctionImport/cg_profile.ll:2
+; Check that RAUW performed by IRMover during function importing does not
+; generate bitcast in "CG Profile" related metadat nodes.
+; RUN: opt -cg-profile -module-summary %s -o %t.bc
----------------
Comment is stale.


================
Comment at: llvm/test/Transforms/FunctionImport/cg_profile.ll:6
+; RUN: llvm-lto -thinlto -o %t3 %t.bc %t2.bc
+; RUN: opt -function-import -print-imports -summary-file %t3.thinlto.bc %t.bc -o %t.o
+
----------------
I guess the test just makes sure this doesn't fail. Would be good to do a check on the output file via llvm-dis that it in fact does have the CG Profile metadata node and that it looks as expected (which I guess now will have the bitcast).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88433/new/

https://reviews.llvm.org/D88433