[PATCH] D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it.

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 07:53:16 PST 2020


clementval added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:489
+  const auto mapEnumListToString =
+      [&](const std::list<parser::OmpMapType::Type> &allowedList) {
+        std::string commaSeperatedList;
----------------
Can you directly assign the result of llvm::interleave to `mapEnumListToString`? Looks like there is an indirection here with an additional temporary. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90834/new/

https://reviews.llvm.org/D90834



More information about the llvm-commits mailing list