[PATCH] D91199: [RISCV] Remove traces of Glue from RISCVISD::SELECT_CC

Thu Nov 12 07:46:42 PST 2020

craig.topper added a comment.

In D91199#2391113 <https://reviews.llvm.org/D91199#2391113>, @asb wrote:

> In D91199#2389105 <https://reviews.llvm.org/D91199#2389105>, @craig.topper wrote:
>
>> In D91199#2388012 <https://reviews.llvm.org/D91199#2388012>, @frasercrmck wrote:
>>
>>> LGTM; from a quick look I can't see anything that would need that glue. Do you have an idea why it was added?
>>
>> No. As far as I could tell it had been there but not used since the first patch that added RISCVISD::SELECT_CC.
>
> I think I'd just copied it across from the equivalent nodes in the Sparc (SPselecticc, SPselectxcc, SPselectfcc) and MSP430 (MSP540selectcc) backends. If it's not required it looks like a similar cleanup could be made there.

It looks like both Sparc and MSP430 do use a Glue input so the td file is correct for them. Sparc does not have a Glue output. MSP430 has an unused Glue output that could be cleaned up.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91199/new/

https://reviews.llvm.org/D91199