[PATCH] D91199: [RISCV] Remove traces of Glue from RISCVISD::SELECT_CC
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 12 05:45:27 PST 2020
asb added a comment.
In D91199#2389105 <https://reviews.llvm.org/D91199#2389105>, @craig.topper wrote:
> In D91199#2388012 <https://reviews.llvm.org/D91199#2388012>, @frasercrmck wrote:
>
>> LGTM; from a quick look I can't see anything that would need that glue. Do you have an idea why it was added?
>
> No. As far as I could tell it had been there but not used since the first patch that added RISCVISD::SELECT_CC.
I think I'd just copied it across from the equivalent nodes in the Sparc (SPselecticc, SPselectxcc, SPselectfcc) and MSP430 (MSP540selectcc) backends. If it's not required it looks like a similar cleanup could be made there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91199/new/
https://reviews.llvm.org/D91199
More information about the llvm-commits
mailing list