[PATCH] D91255: [AArch64] Rearrange (dup(sext/zext)) to (sext/zext(dup))

[Nicholas Guy via Phabricator via llvm-commits]

NickGuy updated this revision to Diff 304529.
NickGuy marked 2 inline comments as done.
NickGuy added a comment.

> This looks like two separate patches to me.

I've pulled the operand sinking out to it's own patch now.

> The first, done universally, will need some thought (and maybe some benchmarks) to make sure it's always the correct thing to do, it's not just something that happens to work here

Agreed, this review request was simply to gather some more opinions on the matter. There was no intention of merging this as-is.

> The fact that no other tests are failing is a good sign at least.

Now that you mention it, it's a bit concerning. It's possible that there are no existing tests covering this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91255/new/

https://reviews.llvm.org/D91255

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/test/CodeGen/AArch64/aarch64-matrix-smull.ll
  llvm/test/CodeGen/AArch64/aarch64-matrix-umull.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91255.304529.patch
Type: text/x-patch
Size: 9288 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201111/8f057a92/attachment.bin>