[PATCH] D91255: [AArch64] Rearrange (dup(sext/zext)) to (sext/zext(dup))
    Dave Green via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Nov 11 07:50:09 PST 2020
    
    
  
dmgreen added a comment.
Hello
This looks like two separate patches to me. One that folds dup(ext(..)) into ext(dup(..)), and another that tries to sink operands into a loop.
They should be separate patches with their own set of tests. The first, done universally, will need some thought (and maybe some benchmarks) to make sure it's always the correct thing to do, it's not just something that happens to work here. The fact that no other tests are failing is a good sign at least.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91255/new/
https://reviews.llvm.org/D91255
    
    
More information about the llvm-commits
mailing list