[PATCH] D91174: [Analysis] Introduce a new InstructionCost class

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 01:18:49 PST 2020


sdesmalen added a comment.

Thanks @david-arm for working on this. It all looks quite sensible to me.

One thing I wondered when looking at this patch is if the templating for the cost type is really necessary, or would it be sufficient to always use `int64_t` as the cost type?
That might simplify the implementation a bit and would remove a level of indirection (i.e. using InstructionCost = GenericCost<unsigned>)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91174/new/

https://reviews.llvm.org/D91174



More information about the llvm-commits mailing list