[PATCH] D91174: [Analysis] Introduce a new InstructionCost class
    Christopher Tetreault via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Nov 10 10:11:13 PST 2020
    
    
  
ctetreau added inline comments.
================
Comment at: llvm/include/llvm/Analysis/InstructionCost.h:34
+  // can be expanded in future to support other cases if necessary.
+  typedef enum {
+    Normal = 0,
----------------
please use `enum class`. Assigning values is unneccesary in this case because it won't magically coerce to an int.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91174/new/
https://reviews.llvm.org/D91174
    
    
More information about the llvm-commits
mailing list