[PATCH] D91092: [SVE][CodeGen] Lower scalable masked gathers

Tue Nov 10 11:28:11 PST 2020

craig.topper added a comment.

In D91092#2386554 <https://reviews.llvm.org/D91092#2386554>, @kmclaughlin wrote:

> @craig.topper  After changing the `refineUniformBase` function in D90942 <https://reviews.llvm.org/D90942> to use getSplatVector() when trying to get the base pointer from a splat, the output of one of the X86 masked gather tests in masked_gather_scatter.ll has changed ("test14", where the base pointer is not a splat, so getUniformBase returns false).
> Could you please take a look over this to make sure the changes are correct in this circumstance?

I think its fine. That code wouldn't have made it past InstCombine in that form. The insertelement would have been deleted by SimplifyDemandedElts.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91092/new/

https://reviews.llvm.org/D91092