[PATCH] D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas

Tue Nov 10 03:53:43 PST 2020

junparser added a comment.

In D90772#2384353 <https://reviews.llvm.org/D90772#2384353>, @bruno wrote:

> Hi @junparser,
>
>> One of the another issue is that it is also necessary to track coroutine function parameters correctly under O1 <https://reviews.llvm.org/owners/package/1/>/O2 <https://reviews.llvm.org/owners/package/2/> level which use dbg.value. Thoughts?
>
> I haven't looked up the coroutine function parameter debugging quality yet, does it even work fine for `-O0`? I'm trying to go over the issues I find for `-O0` first and incrementally improve on top of that. Any specific testcase in mind?

I'm not sure about it, but it should not work fine for O1 <https://reviews.llvm.org/owners/package/1/> above.  I do not have testcase right now, you can just change your testcase to add some parameters and use them.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90772/new/

https://reviews.llvm.org/D90772