[PATCH] D90841: [JumpThreading] Fix branch probabilities in DuplicateCondBranchOnPHIIntoPred()

Tue Nov 10 01:34:27 PST 2020

yrouban added a comment.

In D90841#2377256 <https://reviews.llvm.org/D90841#2377256>, @kazu wrote:

> Your patch looks reasonable.   Is there any way you could come up with a testcase to make sure that the pass indeed copies the probabilities in your testcase?  (Note that I'm not asking for a testcase that exposed this bug before D90284 <https://reviews.llvm.org/D90284>.)

I could not create a simple test. One more option to create one is to change the usage of BPI/BFI to request analysis from AM. Then the test can print BPI to show the difference. I'm not sure this big change is worth this small patch. It is not clear why JumpThreading uses its own local version of BPI/BFI.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90841/new/

https://reviews.llvm.org/D90841