[PATCH] D90939: [SVE][CodeGen] Add the isTruncatingStore flag to MSCATTER

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 07:37:45 PST 2020


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:2444
   MaskedScatterSDNode(unsigned Order, const DebugLoc &dl, SDVTList VTs,
-                      EVT MemVT, MachineMemOperand *MMO,
+                      bool IsTrunc, EVT MemVT, MachineMemOperand *MMO,
                       ISD::MemIndexType IndexType)
----------------
nit: in the other functions like `DAG.getMaskedScatter`, `IsTrunc` is the last parameter after IndexType. Do you want to do that for the constructor as well for consistency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90939/new/

https://reviews.llvm.org/D90939



More information about the llvm-commits mailing list