[PATCH] D90948: [WebAssembly] [WIP] call_indirect issues table number relocs

Andy Wingo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 03:13:55 PST 2020


wingo updated this revision to Diff 303808.
wingo added a comment.

This change, besides fixing some bugs, changes to alwaysmit relocs.  It
will need test fixups.  Can roll back to only emit relocs when
+reference-types if we decide to do that.

- Always emit relocs for table number references in call_indirect

  Instead of enabling relocs only when reference types are enabled, always emit them.  Will need test fixups.
- Allow reading object files with imported tables symtab entries
- Also fix a missing piece in WebAssemblyUtilities::getCallOp
- Also fix a bug reading module name for symtab entries for globals


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90948/new/

https://reviews.llvm.org/D90948

Files:
  llvm/include/llvm/MC/MCSymbolWasm.h
  llvm/lib/MC/WasmObjectWriter.cpp
  llvm/lib/Object/WasmObjectFile.cpp
  llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
  llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
  llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyInstrCall.td
  llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyUtilities.cpp
  llvm/test/MC/WebAssembly/call-indirect-relocs.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90948.303808.patch
Type: text/x-patch
Size: 16396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201109/f0a35ec0/attachment.bin>


More information about the llvm-commits mailing list