[PATCH] D90948: [WebAssembly] [WIP] call_indirect issues table number relocs

[Andy Wingo via Phabricator via llvm-commits]

wingo added a comment.

In D90948#2381935 <https://reviews.llvm.org/D90948#2381935>, @wingo wrote:

> So, just to recap my understanding: before this patch, LLVM will indeed generate the `__indirect_function_table` import and add a corresponding entry to the "linking" section.

FWIW this is incorrect.  LLVM currently makes the `__indirect_function_table` import but does not add a symtab entry to `linking`.  Indeed an undefined table entry there will cause `WasmObjectFile.cpp::parseLinkingSectionSymtab` to carp.  However I think this is probably just a bug, as it doesn't carp for undefined functions (corresponding to imports).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90948/new/

https://reviews.llvm.org/D90948