[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8
    Aleksandr Platonov via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sun Nov  8 23:26:47 PST 2020
    
    
  
ArcsinX added inline comments.
================
Comment at: llvm/CMakeLists.txt:604
+  add_compile_options("$<$<C_COMPILER_ID:MSVC>:/utf-8>")
+  add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>")
 else()
----------------
I think we could replace these two lines with the one line
```
add_compile_options(/utf-8)
```
Because we could not get here with non-MSVC compiler
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90116/new/
https://reviews.llvm.org/D90116
    
    
More information about the llvm-commits
mailing list