[PATCH] D90734: [EarlyCSE] make abs recognization not depend on instcombine abs canonicalize

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 8 07:19:59 PST 2020


spatel added a comment.

The medium-term solution (hopefully not too far away now) is to canonicalize to intrinsics - D87188 <https://reviews.llvm.org/D87188>. Once we get D90554 <https://reviews.llvm.org/D90554> in, we can try that canonicalization again.

So I'm not sure that we want to add to the complexity of early-cse to handle this right now. What if we just delete the code that matches to SPF_ABS / SPF_NABS. I'm not seeing any regression test failures with that, and it avoids the bug?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90734/new/

https://reviews.llvm.org/D90734



More information about the llvm-commits mailing list