[PATCH] D90701: [AArch64][GlobalISel] Select CSINC and CSINV for G_SELECT with constants

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 7 22:25:47 PST 2020


aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:1087
+
+  TryOptSelectCst();
+  auto CSel = MIB.buildInstr(Opc, {Dst}, {True, False}).addImm(CC);
----------------
aemerson wrote:
> Why do we need this as a lambda?
Ok I get why you wanted the lambda. Overall though given that you intend to introduce more lambdas, can you explicitly capture the variables, or pass them in as arguments?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90701/new/

https://reviews.llvm.org/D90701



More information about the llvm-commits mailing list