[PATCH] D90701: [AArch64][GlobalISel] Select CSINC and CSINV for G_SELECT with constants

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:1008
+    unsigned Opc = Is32Bit ? AArch64::FCSELSrrr : AArch64::FCSELDrrr;
+    auto FCSel = MIB.buildInstr(Opc, {Dst}, {True, False}).addImm(CC);
+    constrainSelectedInstRegOperands(*FCSel, TII, TRI, RBI);
----------------
Assert here that False RB is also FPR?


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:1087
+
+  TryOptSelectCst();
+  auto CSel = MIB.buildInstr(Opc, {Dst}, {True, False}).addImm(CC);
----------------
Why do we need this as a lambda?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90701/new/

https://reviews.llvm.org/D90701