[PATCH] D90305: Correctly parse and print Tag_THUMB_ISA_use=3

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 09:13:09 PST 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Please give other reviewers some time to chime in



================
Comment at: llvm/test/MC/ARM/directive-arch-armv8m.s:6
+
+@ RUN: llvm-mc -triple arm-eabi -filetype asm %s \
+@ RUN:   | FileCheck %s -check-prefix CHECK-ASM
----------------
Minor nit: in other places, `|` at the end of the previous line is more common
The next line should be idented, usually by 2, as you already do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90305/new/

https://reviews.llvm.org/D90305



More information about the llvm-commits mailing list