[PATCH] D90837: [BranchProbabilityInfo] Get rid of MaxSuccIdx. NFC

[Kazu Hirata via Phabricator via llvm-commits]

kazu accepted this revision.
kazu added a comment.
This revision is now accepted and ready to land.

Thank you for cleaning this up.



================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:1176
+  // Instead we remove prob data for the block by iterating successors by their
+  // numbers from 0 till the last which exist. There could not be prob data for
+  // a pair (BB, N) if there is no data for (BB, N-1) because the data is always
----------------
s/exist/exists/


================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:1176
+  // Instead we remove prob data for the block by iterating successors by their
+  // numbers from 0 till the last which exist. There could not be prob data for
+  // a pair (BB, N) if there is no data for (BB, N-1) because the data is always
----------------
kazu wrote:
> s/exist/exists/
s/numbers/indexes/


================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:1178
+  // a pair (BB, N) if there is no data for (BB, N-1) because the data is always
+  // set for all successors from 0 to M at once by the public method
+  // setEdgeProbability().
----------------
How about removing `the public method` because we now have only one `setEdgeProbability`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90837/new/

https://reviews.llvm.org/D90837