[PATCH] D90837: [BranchProbabilityInfo] Get rid of MaxSuccIdx. NFC
Yevgeny Rouban via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 5 04:27:14 PST 2020
yrouban created this revision.
yrouban added reviewers: kazu, wmi, efriedma, ebrevnov.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
yrouban requested review of this revision.
This refactoring allows to eliminate the //MaxSuccIdx// map proposed in D90272 <https://reviews.llvm.org/D90272>.
The idea is to remove probabilities for a block BB for all its successors one by one from first, second, ... till N-th until they are defined in //Probs//. This works because probabilities for the block are set at once for all its successors from number 0 to N-1 and the rest are removed if there were stale probs.
I propose to remove the protected method //setEdgeProbability()//, which sets probabilities for individual successors, to make it clear that they are set in bulk in the public method with the same name.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D90837
Files:
llvm/include/llvm/Analysis/BranchProbabilityInfo.h
llvm/lib/Analysis/BranchProbabilityInfo.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90837.303080.patch
Type: text/x-patch
Size: 5756 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201105/5c0a33b6/attachment.bin>
More information about the llvm-commits
mailing list