[PATCH] D90861: [NVPTX] [TableGen] Use new features of TableGen to simplify and clarify

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 10:11:15 PST 2020


tra added a comment.

LGTM. 
I'd add `NFC` to the subject of this patch.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXIntrinsics.td:60
 class THREADMASK_INFO<bit sync> {
-  list<bit> ret = !if(sync, [0,1], [0]);
+  list<bit> ret = !if(sync, [false,true], [false]);
 }
----------------
I'd probably keep this as `0/1`. IMO it's more suitable for a **bit**mask of threads.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90861/new/

https://reviews.llvm.org/D90861



More information about the llvm-commits mailing list