[compiler-rt] 230efef - [NFC] Fix cpplint warnings

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 23:01:48 PST 2020


Author: Vitaly Buka
Date: 2020-11-04T22:56:08-08:00
New Revision: 230efefdbc1dfc025b160dec126adcb69759ba4c

URL: https://github.com/llvm/llvm-project/commit/230efefdbc1dfc025b160dec126adcb69759ba4c
DIFF: https://github.com/llvm/llvm-project/commit/230efefdbc1dfc025b160dec126adcb69759ba4c.diff

LOG: [NFC] Fix cpplint warnings

Added: 
    

Modified: 
    compiler-rt/lib/lsan/lsan_common.h
    compiler-rt/lib/lsan/lsan_thread.h
    compiler-rt/lib/sanitizer_common/sanitizer_deadlock_detector_interface.h
    compiler-rt/lib/sanitizer_common/scripts/check_lint.sh

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/lsan/lsan_common.h b/compiler-rt/lib/lsan/lsan_common.h
index 82323746a096..1fdce087b3a0 100644
--- a/compiler-rt/lib/lsan/lsan_common.h
+++ b/compiler-rt/lib/lsan/lsan_common.h
@@ -33,8 +33,8 @@
 // is missing. This caused a link error.
 #if SANITIZER_ANDROID && (__ANDROID_API__ < 28 || defined(__arm__))
 #define CAN_SANITIZE_LEAKS 0
-#elif (SANITIZER_LINUX || SANITIZER_MAC) && (SANITIZER_WORDSIZE == 64) &&  \
-    (defined(__x86_64__) || defined(__mips64) || defined(__aarch64__) || \
+#elif (SANITIZER_LINUX || SANITIZER_MAC) && (SANITIZER_WORDSIZE == 64) && \
+    (defined(__x86_64__) || defined(__mips64) || defined(__aarch64__) ||  \
      defined(__powerpc64__) || defined(__s390x__))
 #define CAN_SANITIZE_LEAKS 1
 #elif defined(__i386__) && (SANITIZER_LINUX || SANITIZER_MAC)

diff  --git a/compiler-rt/lib/lsan/lsan_thread.h b/compiler-rt/lib/lsan/lsan_thread.h
index a64c19ac5ec6..36643753d019 100644
--- a/compiler-rt/lib/lsan/lsan_thread.h
+++ b/compiler-rt/lib/lsan/lsan_thread.h
@@ -32,7 +32,7 @@ class ThreadContextLsanBase : public ThreadContextBase {
                           void *onstarted_arg);
 
  protected:
-  ~ThreadContextLsanBase(){};
+  ~ThreadContextLsanBase() {}
   uptr stack_begin_ = 0;
   uptr stack_end_ = 0;
   uptr cache_begin_ = 0;

diff  --git a/compiler-rt/lib/sanitizer_common/sanitizer_deadlock_detector_interface.h b/compiler-rt/lib/sanitizer_common/sanitizer_deadlock_detector_interface.h
index 2829d6487b74..7f461c98bade 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_deadlock_detector_interface.h
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_deadlock_detector_interface.h
@@ -90,7 +90,7 @@ struct DDetector {
   virtual DDReport *GetReport(DDCallback *cb) { return nullptr; }
 
  protected:
-  ~DDetector(){};
+  ~DDetector() {}
 };
 
 } // namespace __sanitizer

diff  --git a/compiler-rt/lib/sanitizer_common/scripts/check_lint.sh b/compiler-rt/lib/sanitizer_common/scripts/check_lint.sh
index 4896ddba2e75..85723b194c61 100755
--- a/compiler-rt/lib/sanitizer_common/scripts/check_lint.sh
+++ b/compiler-rt/lib/sanitizer_common/scripts/check_lint.sh
@@ -17,7 +17,7 @@ fi
 # Filters
 # TODO: remove some of these filters
 COMMON_LINT_FILTER=-build/include,-build/header_guard,-legal/copyright,-whitespace/comments,-readability/casting,\
--build/namespaces,-build/c++11,-runtime/int,-runtime/references,-readability/todo
+-build/namespaces,-build/c++11,-runtime/int,-runtime/references,-readability/todo,-whitespace/parens
 
 COMMON_LIT_TEST_LINT_FILTER=-whitespace/indent,-whitespace/line_length,-runtime/arrays,-readability/braces
 


        


More information about the llvm-commits mailing list