[PATCH] D90796: [llvm-objcopy][MachO] Skip sections with zero offset

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

Makes sense to me, but can you add a few examples of binaries which might end up with such sections to the commit message, if you have them? Compatibility with cctools-strip is a pretty compelling reason to make this change IMO.

Will wait for a few days for others to chime in before giving a LGTM.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/zero-offset-section.test:1
+## This test verifies that a regular (non-zero-fill) section with zero offset 
+## is not modifed, this behavior is consistent with cctools' strip.
----------------
Zero offset *and* zero size, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90796/new/

https://reviews.llvm.org/D90796