[PATCH] D90796: [llvm-objcopy][MachO] Skip sections with zero offset.

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 13:39:38 PST 2020


alexshap created this revision.
alexshap added reviewers: MaskRay, jhenderson, smeenai.
alexshap created this object with visibility "All Users".
Herald added a reviewer: rupprecht.
Herald added a subscriber: abrachet.
Herald added a project: LLVM.
alexshap requested review of this revision.

Some binaries can contain regular sections with zero offset and zero size.
This diff makes llvm-objcopy's handling of such sections consistent with cctools's strip (which doesn't modify them),
previously the tool would allocate file space for them.

Test plan: make check-all


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90796

Files:
  llvm/test/tools/llvm-objcopy/MachO/zero-offset-section.test
  llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp
  llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
  llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp
  llvm/tools/llvm-objcopy/MachO/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90796.302961.patch
Type: text/x-patch
Size: 4930 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201104/6ee5de4d/attachment.bin>


More information about the llvm-commits mailing list