[PATCH] D89731: [ms] [llvm-ml] Lex MASM strings, including escaping

[Eric Astor via Phabricator via llvm-commits]

epastor marked 2 inline comments as done.
epastor added inline comments.


================
Comment at: llvm/test/tools/llvm-ml/strings.test:15
+; CHECK-NEXT: .byte 99
+; CHECK-NEXT: .byte 100
+; CHECK-NOT: .byte
----------------
thakis wrote:
> just to verify, these strings are not 0-terminated? (why is the single-char case a special case then?)
Correct - null termination has to be manually added by passing a zero initializer after the string. (e.g., https://stackoverflow.com/q/19033872)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89731/new/

https://reviews.llvm.org/D89731