[PATCH] D89731: [ms] [llvm-ml] Lex MASM strings, including escaping

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

lg if the lack of \0-termination is intentional



================
Comment at: llvm/test/tools/llvm-ml/strings.test:15
+; CHECK-NEXT: .byte 99
+; CHECK-NEXT: .byte 100
+; CHECK-NOT: .byte
----------------
just to verify, these strings are not 0-terminated? (why is the single-char case a special case then?)


================
Comment at: llvm/test/tools/llvm-ml/strings.test:96
+  mov eax, 'a'
+; CHECK: mov eax, 97
+
----------------
Oh I guess for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89731/new/

https://reviews.llvm.org/D89731