[PATCH] D90249: Add options to enable memoryssa for loopsink, expand loopsink testing and fix exposed bug in LICM

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

Thank you, just a couple of small comments below.



================
Comment at: llvm/lib/Transforms/Scalar/LoopSink.cpp:405
   PreservedAnalyses PA;
   PA.preserveSet<CFGAnalyses>();
   return PA;
----------------
```
if (MSSA)
  PA.preserve<MemorySSAAnalysis>();
```


================
Comment at: llvm/lib/Transforms/Scalar/LoopSink.cpp:451
     getLoopAnalysisUsage(AU);
+    if (EnableMSSALoopDependency) {
+      AU.addRequired<MemorySSAWrapperPass>();
----------------
Use `EnableMSSAInLegacyLoopSink` here. This should change the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90249/new/

https://reviews.llvm.org/D90249